phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Handle TODOs in code #93

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

I'd like to turn on the todo-should-have-issue lint rule, which will mean going through the current TODOs to make sure that they are being addressed. Tagging @Luisav1 so she is aware.

zepumph commented 1 year ago

There are 20 TODOs in the repo, and all the didn't currently have TODO issues were marked to this on. I will turn on the lint rule now.

zepumph commented 1 year ago

All TODOs are now pointing to this issue as a fallback. 8 TODOs left. Assigning to @Luisav1, but perhaps we will want to pair to tackle some. Let me know!

zepumph commented 1 year ago

Down to 6 TODOs pointing to this issue.

zepumph commented 1 year ago

Down to just 3 hard TODOs left.

zepumph commented 1 year ago

RE: https://github.com/phetsims/build-a-nucleus/blob/170469f36bf31a52b5785645d161af6ae8752a61/js/common/model/BANModel.ts#L100

I used this script to confirm that recalculateNucleus doesn't shuffle around particles:

 this.particleAtom.massNumberProperty.link( () => {
      this.particleAtom.reconfigureNucleus()
      for ( let i = 0; i < 10; i++ ) {
        setTimeout( () => {
          console.log( 'hi' );
          this.particleAtom.reconfigureNucleus()

        }, i * 500 );

      }
    } );
zepumph commented 1 year ago

There are no TODOs left pointing to this issue. Closing!