Closed zepumph closed 1 year ago
There are 20 TODOs in the repo, and all the didn't currently have TODO issues were marked to this on. I will turn on the lint rule now.
All TODOs are now pointing to this issue as a fallback. 8 TODOs left. Assigning to @Luisav1, but perhaps we will want to pair to tackle some. Let me know!
Down to 6 TODOs pointing to this issue.
Down to just 3 hard TODOs left.
I used this script to confirm that recalculateNucleus
doesn't shuffle around particles:
this.particleAtom.massNumberProperty.link( () => {
this.particleAtom.reconfigureNucleus()
for ( let i = 0; i < 10; i++ ) {
setTimeout( () => {
console.log( 'hi' );
this.particleAtom.reconfigureNucleus()
}, i * 500 );
}
} );
There are no TODOs left pointing to this issue. Closing!
I'd like to turn on the todo-should-have-issue lint rule, which will mean going through the current TODOs to make sure that they are being addressed. Tagging @Luisav1 so she is aware.