search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

Errors in periodic table #104

Closed amyh-phet closed 8 years ago

amyh-phet commented 9 years ago

@jbphet there appears to be a bug in Build an Atom. Period 6 and 7 elements (rows 6 and 7) are incorrect after Ba. Errors occur on Atom, Symbol, and some game screens.

oliver-phet commented 8 years ago

A user emailed PhET help about this issue. @jbphet And I discussed, and it may make sense to wrap this fix into the next maintenance release of BaA.

aadish commented 8 years ago

Build an atom is now using the periodic table in the shred repository, which has this issue fixed. @jbphet can you look at it?

jbphet commented 8 years ago

For reference, here is a screenshot of the periodic table in the version of BAA that is currently published on the PhET website: baa-periodic-table-with-errors

Here is the table from the current version on the master branch: baa-periodic-table-fixed

I compared the latter to several tables that I found on line, and it looks correct. However, the background color is gray and used to be white. Assigning back to @aadish to fix this. This might involve adding an option for backgroundColor to the periodic table code.

aadish commented 8 years ago

Added options for enabled , disabled and selected cell color.

jbphet commented 8 years ago

Looks good. Assigning to @amyh-phet to look at the table and verify. It should probably be checked on all three screens.

amyh-phet commented 8 years ago

Checked all screens and verified that the periodic table is correct. Assigning to @jbphet to deploy.

jbphet commented 8 years ago

Closing, since @amyh-phet says the table looks good.