search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

use new scoreboard? #110

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Consider switching from ScoreboardPanel to ScoreboardBar, for the following reasons:

(1) Having ScoreboardBar at the top of the screen is more tablet friendly. (2) Because of (1), we've done this in other sims, and should probably do the same here. (3) It would be nice to get rid of ScoreboardPanel, so we don't have to maintain it (it currently fails stringTest). Currently it's used only by build-an-atom and balancing-act.

How ScoreboardPanel currently looks in Build An Atom:

screenshot_99

Example of ScoreboardBar in Graphing Lines:

screenshot_101

samreid commented 8 years ago

As I'm starting to instrument this game, I'm also wishing this used the non-deprecated ScoreboardBar. I'll continue with ScoreboardPanel for now, but a switch soon would be very nice.

jbphet commented 8 years ago

Assigning to @ariel-phet to decide if someone (most likely me) should just do this or whether we need to do any design review and/or discussions. I believe the API for the new scoreboard is very similar to that of the old one, so switching should take an hour or less.

pixelzoom commented 8 years ago

build-an-atom looks like a straightforward retrofit, with no design/layout changes required. Plenty of room at the top for a scoreboard, and definitely in the spirit of why designed this new scoreboard.

balancing-act may be a little trickier.

ariel-phet commented 8 years ago

I am going to bounce this over to @amyh-phet to get her opinion.

@amyh-phet what say you? Perhaps do a quick mockup to see how you would feel about the change? Seems clean and nice to me.

jbphet commented 8 years ago

In my opinion, the new scoreboard would look good in the sim.

amyh-phet commented 8 years ago

@pixelzoom @samreid @jbphet @ariel-phet I agree that the new scoreboard looks good. Did a quick mockup with screenshots from Build an Atom and like the new look. Sounds like it will solve some functionality issues as well.

samreid commented 8 years ago

Sounds like it will solve some functionality issues as well.

Any time we have the opportunity to delete 134 lines of common code, we should pounce on it :smile:

aadish commented 8 years ago

new scoreboard has been added assigning to @jbphet to review

jbphet commented 8 years ago

The new scoreboard has been integrated and the layout of the challenges has been adjusted to look good. Closing.