search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

buildAnAtom.homeScreen.activeProperty: TProperty not toggling #160

Closed EthanWJohnson closed 7 years ago

EthanWJohnson commented 7 years ago

Judging by the other active properties (such as buildAnAtom.symbolScreen.activeProperty: TProperty) which toggle to true when the appropriate screen is active, buildAnAtom.homeScreen.activeProperty: TProperty doesn't toggle true OR false when the home screen is entered or left. I imagine it should be toggling based on whether the home screen is on.

Related to https://github.com/phetsims/tasks/issues/847

phet-steele commented 7 years ago

@EthanWJohnson is this in Instance Proxies? I see it toggle correctly in the Events: colorized wrapper.

phet-steele commented 7 years ago

@EthanWJohnson is this in Instance Proxies? I see it toggle correctly in the Events: colorized wrapper.

Nevermind, confusing it with buildAnAtom.sim.showHomeScreenProperty.

EthanWJohnson commented 7 years ago

Yeah, its not toggling in either.

EthanWJohnson commented 7 years ago

Noting that homeScreen.active still doesn't toggle in 1.4.0-phetiorc.2, for https://github.com/phetsims/tasks/issues/850

zepumph commented 7 years ago

This is fixed in master now. I will pull it into the branch later.

phet-steele commented 7 years ago

Looks fixed, thanks.