Closed phet-steele closed 7 years ago
I found the cause I think:
options = _.extend( {
labelNode: new Text( bucket.captionText, {
font: new PhetFont( 20 ),
fill: bucket.captionColor,
tandem: Tandem.tandemRequired().createTandem( 'label' )
} )
}, options );
This tandemRequired() call is never being overridden for default label nodes, I need to pull this labelNode out of the options.
Alright I updated these lines and there are no more cases of 'required' in instance proxies. I will cherry pick into branches later.
Looks good to me, thanks.
Here is an example for the Protons bucket on the first screen. Note that no useful information is presented in the instance name, like screen or bucket the label belongs to:
The same instance from a previous version https://phet-io.colorado.edu/sims/build-an-atom/1.4.0-phetio/wrappers/instance-proxies/instance-proxies.html?sim=build-an-atom shows that the instance name was fine at one point (see #163 if the version number is confusing).
Seen on Win 10 Chrome and FF. For phetsims/tasks/issues/850.