search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

[Game Screen] Uninstrument unnecessary instrumentation #178

Open samreid opened 6 years ago

samreid commented 6 years ago

In https://github.com/phetsims/build-an-atom/issues/156#issuecomment-324741883 we discussed the features we want to be instrumented for Build an Atom. After we have a full PhET-iO design meeting about Build an Atom, we will need to go through and remove unused instrumentation.

samreid commented 6 years ago

There are 51 instance proxies at the moment, several seem unnecessary.

samreid commented 6 years ago

I skimmed through instance proxies and made a revision here and another in axon, but it will be best to review this with @jbphet as part of #156, on hold until then.

jbphet commented 6 years ago

@samreid - I'd rather not have this assigned to me unless there is something that I need to do on it, but the "on-hold" label is applied to it. Did you want me to review the changes that you just made? Or are you asking me to take a pass through and uninstrument the things that are, in my judgement, not necessary to have instrumented for PhET-iO?

samreid commented 6 years ago

I thought this would be good to collaborate on when we continue on #156. I generally mark things as "on-hold" for things that need to be on my radar but not on my immediate to do list.

samreid commented 6 years ago

Unassigning until after we have a PhET-iO design meeting.