phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

User reported issue: +/- Ion symbol ordering. #180

Closed oliver-phet closed 1 year ago

oliver-phet commented 6 years ago

In IUPAC 2005 http://old.iupac.org/publications/books/rbook/Red_Book_2005.pdf

IR-3.2 INDICATION OF MASS, CHARGE AND ATOMIC NMBER USING INDEXES (SUBSCRIPTS AND SUPERSCRITS) ... right upper index charge A charge placed on an atom of symbol A is indicated as An+ or An-, not as A+n or A-n.

But in HTML5 sims it appears as +n

oliver-phet commented 1 year ago

We just received another request for customizing the order of the ion symbol from our German translators:

As this sim is used to teach the difference between atoms and ions and ions are written as "Be2+" or "S2-", I find the representation in the sim slightly confusing for students ("Be+2"). It would be easier for them to link the proton and electron numbers from the sim with the ions they encounter in reactions if the representation of multiple charges were the same. For a single atom the charge can well be represented in the "2+" way, as it is common for ions.

oliver-phet commented 1 year ago

Assigning to @DianaTavares since she is the responsible designer!

DianaTavares commented 1 year ago

I ask Robert Parson about this, and this is his answer:

Having the number before the charge, e.g. Ca2+, is the usual convention in chemistry and is probably what the sim should use. Note that chemists also commonly omit the numeral “1” when there is a single charge, but when the eim was designed the designers chose to keep it in order to make the notation as clear as possible for newcomers, and I would recommend continuing to do so.

I know that this simulation is also used for some math activities related to negative/positive integers numbers, then one option is to have both representation with a query parameter. Other way I think is better to use what is correct for a chemistry standpoint, an that mean the +/- to the right of the number.

It is a super easy change in the sim, but I feel that this need a little of discussion, then I would like to know @ariel-phet , @arouinfar and @amanda-phet (for the math side) opinion.

jbphet commented 1 year ago

To aid in the discussion, here are a couple of screenshots. First is the notation recommended in the document:

image

Here is how the sim currently depicts the same ionic charge:

image

amanda-phet commented 1 year ago

The math activities that use this sim rely on the "net charge" feature on the first screen of this sim, so I'm not sure the changes being discussed here would impact those lessons. Thank you for taking them into consideration!

arouinfar commented 1 year ago

We are clearly not using the standard charge notation. Looking at the sim credits, a fair number of chemistry experts were a part of the team, so I suspect we made a deliberate choice to use ±n instead of , likely to make the simulation more accessible to younger learners. Skimming through the design doc, I didn't see a documented reason, though.

I wouldn't be surprised if a large number of users, especially those in universities or abroad, would prefer to use the standard IUPAC notation. This seems like a good candidate for a query parameter that corresponds to a radio button group in the Simulation tab of the Preferences. Perhaps something like this:

image

I don't have a great idea for the query parameter name, but perhaps chargeNotation=signFirst and chargeNotation=signLast could work.

I'd be curious to hear input from @emily-phet or @BLFiedler since they have more expertise in this area.

DianaTavares commented 1 year ago

I really like @arouinfar idea! It supports early learners and the math application of this sim. We can have the default the ±n, and advanced teachers to change it to the standard notation.

brettfiedler commented 1 year ago

It does strike me as a good candidate for the preferences menu, as more folks will see it than only an advertised query parameter in say the teacher tips. With respect to how the pref menu and query parameter interact, you may have to finesse.

For example, re: how the query parameter and pref menu buttons might interact: We're currently using a toggle in the Sim tab of the Pref menu for Quadrilateral which changes two parameters at once and are also (currently) query parameters. Toggling this ON in the pref menu will override the "step size" query parameter and then revert to the query parameter otherwise when off. For the other parameter toggling it ON changes a scaling factor (for a tolerance), so the query parameter is carried through the calculation when toggling.

image

This might be more akin to what happens when sound is muted initially though? The query parameter affects the state of the preferences menu Sounds toggle:

image

arouinfar commented 1 year ago

Discussed in 10/20/22 design meeting @ariel-phet @kathy-phet @jbphet @Nancy-Salpepi @arouinfar

Next steps:

arouinfar commented 1 year ago

@jbphet I added this to the Issues of Choice project board. BAA contains an error in the charge notation that would be nice to address. I did a deep review of the sim to make sure we caught all the places where the charge notation appears.

Places to update charge notation:

jbphet commented 1 year ago

@arouinfar - This is fixed on master and in the 1.6 branch, which is the branch from which the current published version is derived. Can you please look it over (on master) and make sure you're good with the behavior? I ended up having to use some different minus signs for when the sign is before the number (unary minus) and after (normal minus) to keep things consistent with plus signs and looking reasonably good. I'd like you to check it out before we move to the next phase. If you're good with it, I'll create an RC and have you check that over in greater detail.

jbphet commented 1 year ago

If I end up needing to propagate these changes to the 1.7 branch of BAA, here is a list of the commits that were applied to the master branch to make the changes:

arouinfar commented 1 year ago

Thanks @jbphet. I tested on master and played through the game a few times, and the signs are all looking good.

I ended up having to use some different minus signs for when the sign is before the number (unary minus) and after (normal minus) to keep things consistent with plus signs and looking reasonably good.

Good call! I think it would have looked strange otherwise.

jbphet commented 1 year ago

Thanks @arouinfar. I've published an RC for this, please check it out at https://phet-dev.colorado.edu/html/build-an-atom/1.6.25-rc.1/build-an-atom_en.html. I talked with QA, and they have a fair amount on their plate at the moment, so I'm okay with having you and me verify this if you are. Please test drive it, let me know if you see any issues and, if not, I'll check it over one more time and proceed with publication if we don't find any problems.

arouinfar commented 1 year ago

I talked with QA, and they have a fair amount on their plate at the moment, so I'm okay with having you and me verify this if you are.

Sounds reasonable to me.

Please test drive it, let me know if you see any issues and, if not, I'll check it over one more time and proceed with publication if we don't find any problems.

Thanks @jbphet. Everything looks good on my end.

jbphet commented 1 year ago

I just published version 1.6.25 with the change discussed above.

@oliver-phet - I'm assigning this back to you in case you want to notify the folks who requested this change that it has been implemented. After that, feel free to close.

oliver-phet commented 1 year ago

All 3 users emailed with a link to the new version!

arouinfar commented 1 year ago

Thanks @oliver-phet @jbphet! I've uploaded the updated Teacher Tips to the website.