search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

Third Game directs to second #187

Closed JRomero0613 closed 6 years ago

JRomero0613 commented 6 years ago

Test device: PC Laptop

Operating System: Windows 10 v. 1803

Browser: Chrome v. 67.0.3396.99

Problem description: When clicking on the third game on the game screen the user is redirected to the second game rather than the third game.

Steps to reproduce: Open the sim, navigate to game screen, and start the third game from the left, it will open the second game and not the third. As you can see in the gif below the second and third game buttons both direct to the second game.

Screenshots: baa_wrong_game

jessegreenberg commented 6 years ago

@JRomero0613 I actually think that @jbphet is the responsible dev for this sim. But if there was another reason I was assigned this issue please let me know.

jbphet commented 6 years ago

Nice catch @JRomero0613. This was caused by a cut-and-paste error introduced in https://github.com/phetsims/build-an-atom/commit/cc95a35b78260e6c3373a9db4c25ef8b31888dcb. I've fixed it, and also cleaned up the code to reduce duplication, which should help prevent something like this from happening again. Closing.