search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

PhET-iO Automated Testing Error #193

Closed samreid closed 5 years ago

samreid commented 5 years ago

Bayes CT is offline now, but earlier today build-an-atom reported a PhET-iO error. @zepumph and @samreid bravely volunteered to investigate.

KatieWoe commented 5 years ago

@samreid looks like this may be the issue.

build-an-atom : phet-io-fuzz : require.js : run
Uncaught Error: Assertion failed: Cannot register two different instances to the same id: buildAnAtom.gameScreen.view.challenges_0View.countsToElementChallengeView.neutralAtomRadioButton.inputListener.pressedEmitter
Error: Assertion failed: Cannot register two different instances to the same id: buildAnAtom.gameScreen.view.challenges_0View.countsToElementChallengeView.neutralAtomRadioButton.inputListener.pressedEmitter
    at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/assert/js/assert.js:22:13)
    at Phetio.addInstance (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/phet-io/js/phetio.js?bust=1538066331694:645:19)
    at Object.addInstance (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/phet-io/js/phetio.js?bust=1538066331694:749:14)
    at Tandem.addInstance (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/tandem/js/Tandem.js?bust=1538066331694:134:36)
    at Emitter.initializePhetioObject (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/tandem/js/PhetioObject.js?bust=1538066331694:151:19)
    at Emitter.PhetioObject [as constructor] (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/tandem/js/PhetioObject.js?bust=1538066331694:80:12)
    at new Emitter (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/axon/js/Emitter.js?bust=1538066331694:37:18)
    at FireListener.PressListener [as constructor] (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/scenery/js/listeners/PressListener.js?bust=1538066331694:283:28)
    at new FireListener (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/scenery/js/listeners/FireListener.js?bust=1538066331694:44:19)
    at new AquaRadioButton (https://bayes.colorado.edu/continuous-testing/snapshot-1538065377792/sun/js/AquaRadioButton.js?bust=1538066331694:117:25)
Approximately 9/27/2018, 10:22:57 AM
samreid commented 5 years ago

This suggests a missing dispose function in countsToElementChallengeView. However, I am not seeing this in about 5 minutes of fuzz testing the game screen, nor do I see it on recent Bayes CT columns.

samreid commented 5 years ago

I do see the expected disposal functions and call sites, so I recommend to close this issue until it recurs.