Convert usages of `get Node.disposed` to use `Node.isDisposed`

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/build-an-atom

GNU General Public License v3.0

11 stars 10 forks source link

Convert usages of `get Node.disposed` to use `Node.isDisposed` #199

Closed samreid closed 5 years ago

samreid commented 5 years ago

From https://github.com/phetsims/scenery/issues/899, we would like to be consistent about using isDisposed instead of disposed. Some cases in Build an Atom declare their own subtype attribute for disposed, even though they extend a type that already tracks isDisposed such as Node or PhetioObject. See also comment in https://github.com/phetsims/scenery/issues/899#issuecomment-462371251

Assigning to responsible dev for investigation.

jbphet commented 5 years ago

Investigated, changed usages of dispose to isDisposed. I don't think this requires a review, but @samreid is welcome to take a look if he'd like. Closing.