search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

API mismatches present #204

Closed zepumph closed 5 years ago

zepumph commented 5 years ago

Looks like some tandems changed and crashed the phet-io version of the sim.

zepumph commented 5 years ago

Fixed by running grunt update which regenerated the PhET-iO baseline api. Tagging @SaurabhTotey because he committed the change. A great way to catch this is the launch the sim in phet-io standalone mode, in phetmarks or with query parameters ?brand-phet-io&phetioStandalone. Over to @SaurabhTotey to review.

zepumph commented 5 years ago

Please see https://github.com/phetsims/phet-io/issues/1443#issuecomment-484306552 for a verbose explanation of supporting the phet-io api for simulations.

SaurabhTotey commented 5 years ago

Oh yeah, this is my bad. I believe I caused the issue while I was working on https://github.com/phetsims/shred/issues/22. I'll be sure to be more careful with changes in this regard. Thanks for the heads up!

zepumph commented 5 years ago

Not a worry, and thank you!