search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

String missing colon and space in ES6 version of BAM #211

Closed ghost closed 4 years ago

ghost commented 4 years ago

For https://github.com/phetsims/QA/issues/482. Katie and I weren't sure if this had anything to do with ES6, so this issue might need to be moved to a different repo.

Platform: iOS 12

ES6 - "Puntuación0":

new

Published - "Puntuación: 0":

published

KatieWoe commented 4 years ago

es_PE sim: esPE It seems this is not in every locale. Not sure what that means for the issue.

jonathanolson commented 4 years ago

In babel (vegas-strings_es.json) I'm seeing this translation:

  "pattern.score.number": {
    "value": "Puntuación{{score}}",

It looks like the sim's been refactored to use newer code that uses a different string.

So this seems like a sim-specific translation-specific issue.

KatieWoe commented 4 years ago

In that case, moving reps and assigning to @jbphet since this is his sim.

jbphet commented 4 years ago

I went through the translation files, and it appears to me that es was the only locale with this problem. Looks like it was just a bad translation, and some refactoring of the scoreboard that occurred a while back made it appear. I went ahead and directly fixed the translation file by making the string match the one for the other string with essentially the same pattern. It looks good on master now (screenshot below), so should be fine in the next deploy. Closing.

image