search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

dead code in BuildAnAtomModel #219

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

Noted while working on https://github.com/phetsims/tasks/issues/1052.

There is a chunk of dead (commented out) code in BuildAnAtomModel. Delete it or document why it shouldn't be deleted.

jbphet commented 3 years ago

Thanks for pointing this out. The code in question was commented out when fixing an issue with repositioning the nucleus when the "show stability" setting changed (see #146), and I must've missed permanently deleting it. It's gone now. Closing.