search

phetsims / build-an-atom

"Build an Atom" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/build-an-atom
GNU General Public License v3.0
11 stars 10 forks source link

Properties should have `Property` suffix #94

Closed pixelzoom closed 8 years ago

pixelzoom commented 9 years ago

See https://github.com/phetsims/beers-law-lab/issues/86

Examples of anti pattern (not exhaustive):

CountsToChargeProblemView: this.chargeAnswer = new Property( 0 ); CountsToMassNumberProblemView: this.massNumberAnswer = new Property( 0 ); InteractiveSymbolNode: thisNode.protonCount = new Property( options.interactiveProtonCount ? 0 : numberAtom.protonCount ); InteractiveSymbolNode: thisNode.massNumber = new Property( options.interactiveMassNumber ? 0 : numberAtom.massNumber ); InteractiveSymbolNode: thisNode.charge = new Property( options.interactiveCharge ? 0 : numberAtom.charge );

jbphet commented 8 years ago

@aadish is currently working on cleanup of this simulation, assigning to him for resolution.

aadish commented 8 years ago

fixed, closing