phetsims / buoyancy-basics

"Buoyancy: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Move pool to the left on both screens. #11

Closed zepumph closed 1 month ago

zepumph commented 2 months ago

This is to account for the pool scale height slider.

Things to consider:

zepumph commented 2 months ago

Noting https://github.com/phetsims/buoyancy-basics/issues/10

AgustinVallejo commented 1 month ago

Just for the record, we tried moving the camera and duh, perspective spoiled the party:

image

Will try other solutions

AgustinVallejo commented 1 month ago

There's just one thing to maybe redesign here: Since the pool moved to the left, now the scale and red block on the Compare Screen don't fit and bounce against the screen bounds. Maybe thinking of a new position for the red block @DianaTavares

DianaTavares commented 1 month ago

It is perfect!!

Thanks!

zepumph commented 1 month ago

now the scale and red block on the Compare Screen don't fit and bounce against the screen bounds. Maybe thinking of a new position for the red block @DianaTavares

This doesn't seem complete. Let's discuss

zepumph commented 1 month ago

@DianaTavares, how would you like to handle the left side masses? The block positions are further to the left than the bounds allow, so resetting caused an animation ending in the block resting partially out above the pool:

image

We could change the initial positions, but I can't see how to do that when without pool overlap with the large olive block on the left:

image

What do you think?

AgustinVallejo commented 1 month ago

@zepumph I already spoke to @DianaTavares and will fix this. We'll invert the blocks sizes. Just haven't gotten to it yet

AgustinVallejo commented 1 month ago

image

When implementing the change, the yellow block is now really close to black... Are we ok with this? @DianaTavares

AgustinVallejo commented 1 month ago

@DianaTavares says: está bien!

Closing