search

phetsims / buoyancy-basics

"Buoyancy: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Blocks under the scale inside the fluid, and the user drawing down the scale #14

Closed DianaTavares closed 4 months ago

DianaTavares commented 4 months ago

Right now it looks like this: image

I wonder if the slider can know where the block is and not to get down merging with the block. Other idea is to make the space below the scale inaccessible for the blocks. Other ideas?

samreid commented 4 months ago

In discussion with @DianaTavares and @AgustinVallejo we agreed the best solution is to prevent blocks from being dragged underneath the scale.

samreid commented 4 months ago

@AgustinVallejo and I worked on it in the commit. @DianaTavares can you please test this on phettest? Please close if ok.

AgustinVallejo commented 4 months ago

Noting that this change introduced a new bug, which is probably going to be very hard to solve: When you move the pool scale up very fast, small blocks on top of the scale can fall through into the wall. How much effort should we put in fixing that?

Image

DianaTavares commented 4 months ago

Te wall is working well!

but the bug is very distracting and easy to reproduce. It happens not only with small blocks, all blocks that fit below the scale can present this problem: image

@AgustinVallejo indicates that it is "very hard" but approximately how much time? I will bring this to my meeting with @kathy-phet but we will need a reference to make a decision.

AgustinVallejo commented 4 months ago

@DianaTavares nevermind, we figured how to teleport the blocks when they found themselves trapped. Pushing a fix below

DianaTavares commented 4 months ago

love it!! I will close