Compare Screen: Depth lines should change color as density changes

[zepumph]

From https://github.com/phetsims/buoyancy-basics/issues/5#issuecomment-2096690650:

• Also, the color of depth lines is not changing to white when the block's material gets dark:

[samreid]

I'm confused about this issue, since I see the depth lines change color when changing the density of a custom material:

The supporting code was committed in https://github.com/phetsims/density-buoyancy-common/commit/12db36882efb7521833ee9ab173c2219fba01400. What remains to be done for this issue?

[zepumph]

Here is where we are creating colors of materials for the compare screen,

https://github.com/phetsims/density-buoyancy-common/blob/552498deb280f47bd6b59a568936a381b706cc1c/js/common/model/CompareBlockSetModel.ts#L249-L254

[AgustinVallejo]

Added the same logic of the custom block, please review @DianaTavares

[DianaTavares]

I love that now the lines change with the density! But I think it does a little late. Currently, the change to white is in density 1.17 kg/L

Look, these blocks have a density of 0.35 kg/L and I think that iut should be the moment to change! I edited the picture to change the lines to white and they have better contrast.

[AgustinVallejo]

Please review the new threhold

[DianaTavares]

Amazing!!

[zepumph]

Just noting here that this threshold changes for all screens. I looked at the lab screen and the contrast looks really good.