search

phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Custom mass/volume range should always be the full range of the NumberControl? #115

Closed zepumph closed 2 months ago

zepumph commented 2 months ago

From https://github.com/phetsims/buoyancy/issues/31, we found that the max custom mass is set to 100, but that seems arbitrary, and like it shouldn't hard coded. Instead, why not always have it be the full range of the number control?

zepumph commented 2 months ago

Over in https://github.com/phetsims/buoyancy/issues/31#issuecomment-1979805691 @DianaTavares confirmed that this is the right behavior to implement.

zepumph commented 2 months ago

In density, we kept the mas for custom to match the max of the density readout. So that seems like a reasonable constraint there.

zepumph commented 2 months ago

I discussed with @DianaTavares and got all the custom ranges sorted out. Another issue may be necessary to fix how the custom material selector works for the bottle screen, since it is more important there for it to maintain the same density as the volume changes. @DianaTavares will make that issue if it is needed. Thanks!