Closed DianaTavares closed 1 month ago
@AgustinVallejo will take the lead on this, and will look at https://ambientcg.com/ (where other textures came from as documented in https://github.com/phetsims/density-buoyancy-common/blob/843a0377d3423df92dd070f875f0a6e8dcf4c4cc/images/license.json#L30. Thanks!
Reminder to also do some work on Mystery Materials:
This is ready to review, let me know if this is what you wanted @DianaTavares
Just noticed I missed the PVC, please review the rest while I implement that.
I only have one observation: The custom material now looks strange. With a small density (considering that its density range is from 0.1 to 27 kg), it is already black (look at the picture). Density also has a full black block with a small density (3.1 kk/L), but the range goes to 10 kg/L. I feel that the gray-black gradient needs to be bigger here.
Addressing last Diana's comment in https://github.com/phetsims/buoyancy/issues/128 since that's not consequence of the changes done here. Closing this one as completed.
I am not sure if this can be improved but, the list of the “original” materials of the simulations (the ones in Density) looks like the real colors/textures materials, (like brick, ice, etc). The new materials, in some cases, are just colored blocks. I remember in previous Jonathan experiments with this simulations, that he created blocks of metals that look like shinning, that effect can work for some material in the list. The ones that I will can be improved are:
PVC It is a gray block:
I associate it more with a white color. It is possible to have the effect of a 3D-printed block?
Pyrite and Gold Now it is a kind of orange block:
I think that something more "mirror" and shinning effect, yellow block
Silver In the simulation, silver is the same color that gold:
At least something gray:
Tantalum Also, the same color that gold in the simulation. I am thinking in the same that Aluminum but darker:
Or like silver, but less shining:
Platinum Looks like it should be like silver, bur wither.