phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Changes in the Material control in the Bottle-Applications screen #120

Closed DianaTavares closed 3 weeks ago

DianaTavares commented 2 months ago

With this control is not possible to have a custom material with a specific density, and fill the bottle with it. image

Proposal: For known materials: image

For custom: image

Where the density goes from 0.05 kg/L to 20 kg/L

For mystery: image

Material R: Ice (0.92 kg/L) Material S: Lead (11.34 kg/L)

zepumph commented 1 month ago
zepumph commented 3 weeks ago

Working on this now.

zepumph commented 3 weeks ago

I believe a rough draft is in place now. The implementation is a bit rough (9 TODOs), but it would be a good time to check in with @DianaTavares.

Please also note that we need colors for the new mystery materials (checkbox above).

zepumph commented 3 weeks ago

Ok. I think that a sync conversation would be best to continue here. There is some nuance about being able to set the min volume to 0 on the custom material. It may not be worth the cost. Let's talk tomorrow.

DianaTavares commented 3 weeks ago

We. can discuss this after the stand-up meeting tomorrow! Some ideas:

In this picture, we have a minvolume for custom. I don't believe we will need this once the volume doesn't change the density.

I agree! The min can be 0.

The empty bottle defaults to 100g. @kathy-phet and I like decreasing that a bit.

I see the discussion in Slack. The volume of the shell of the bottle is 0 to be practical. for the same reason, the mass is 100g, because is an easy operation for the student to make the operations. I think this screen needs to have the bottle's mass label by default

Decide on colors for above mystery materials

I like the colors they have now! but less shining. I tried to play with the color editor, but I didn't find the colors for materials S and R. But I think that if you go to a darker gradian in the top, it will be ok! look how the copper is not so shinning: image image

DianaTavares commented 3 weeks ago

Continue with the conversation related to colors, I decide the color for the second mystery material (R)

(255, 115, 0, 0.61) Orange: image

Mystery Material S is good with the changes done in the meeting we had yesterday: image

In this picture, we have a minvolume for custom. I don't believe we will need this once the volume doesn't change the density. In yesterday's meeting we also agreed that the volume can be the min that is already in the code (it is not zero, and @zepumph comments that change that can be challenging, and the truth is that we don't need it to be zero)

We also agree that this screen needs to:

zepumph commented 3 weeks ago

I also have:

The empty bottle defaults to 100g. @kathy-phet and I like decreasing that a bit.

Do we want this?

DianaTavares commented 3 weeks ago

No, let's leave it to 100g because is a more manageable number and evident that the bottle have mass by itself

zepumph commented 3 weeks ago

Alright. This is complete. Thanks all!