phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Mystery Materials #121

Closed DianaTavares closed 1 month ago

DianaTavares commented 2 months ago

We agreed in add them to Lab and Applications. These are the suggestions:

Material O: Human (0.95 kg/L) - 5L - 4.75 kg - color: red Material P: Diamond (3.51 kg/L) - 5 L -15.44 kg, color- green

Material V: Titanium (4.5 kg/L) - 6L - 27 kg - Color yellow Material W: Mercury (13.59 kg/L) - 3L - 40.77kg - color blue

We already have this implementation in Explore, but with the mane "mystery": image

Why material and not mystery? All the other mystery values in the simulation, we don't use the word mystery, in place we use something related to the variable:

image

Bottle also need mystery materials, but that was described in the #120 issue.

AgustinVallejo commented 1 month ago

Regarding the Applications request, it seems to be a bit crowded. Right now the entire combo box doesn't even fit. It can be moved up but just wanted to check this is a direction we want to move towards. (The hidden last element is Custom) @DianaTavares image

DianaTavares commented 1 month ago

Yes please, try to move it up. Wow it is a big list!

AgustinVallejo commented 1 month ago

Almost done by the above commit. For some reason the panel in Applications Screen View is not automatically changing to the mystery message, will investigate tomorrow.

Looking like this now: image

AgustinVallejo commented 1 month ago

Assigning to @DianaTavares to review this feature (except the colors which I'll work on https://github.com/phetsims/buoyancy/issues/116). Feel free to close if ready :)

DianaTavares commented 1 month ago

Perfecto! Thanks!