Factor out map calls to readout items?

phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

2 stars 2 forks source link

Factor out map calls to readout items? #127

Closed zepumph closed 1 month ago

zepumph commented 1 month ago

From https://github.com/phetsims/buoyancy/issues/112, it may be nice to not duplicate the readout item creation from the density and submerged panels.

https://github.com/phetsims/density-buoyancy-common/blob/5d407dbed63da3a25ff1d95e435b715ad50b0615/js/buoyancy/view/BuoyancyExploreScreenView.ts#L127-L143

Just something to think about, and something that I was required to do over in https://github.com/phetsims/buoyancy/issues/96 since we don't know what blocks we may have as they change.

zepumph commented 1 month ago

@AgustinVallejo and I like it the way it is (with two map calls). Closing