search

phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Review "fluid displaced" panel on the lab screen #129

Closed zepumph closed 1 month ago

zepumph commented 1 month ago

I added the fluid displaced panel over in https://github.com/phetsims/buoyancy/issues/113. And I think it is ready for review. Here is what it currently looks like:

image

Let me know what you think!

DianaTavares commented 1 month ago

wow, thanks @zepumph!! I have some comments:

  1. the color of the fluid inside the beaker needs to be the same color as the fluid in the pool (because is the fluid displaced from the pool)

  2. Related to the previous point, it is not just the color of the fluid, it needs to change its density to fit the ones in the poll, in that way, the buoyancy force has always the same value that the weight of that fluid displaced. image

  3. It is covering part of the ground, which is not ideal. I call for a design meeting to discuss this because one option is to make it smaller to fill bellow the ground, but I hope that with more designers' eyes, we can find a better idea.

zepumph commented 1 month ago

It stays on under the ground now. image

zepumph commented 1 month ago

Ok, color and newton calculation should be fixed now too. Anything else for this panel right now?

DianaTavares commented 1 month ago

I looks amazing!! thanks @zepumph !!

phet-dev commented 1 month ago

Reopening because there is a TODO marked for this issue.

phet-dev commented 1 month ago

Reopening because there is a TODO marked for this issue.

zepumph commented 1 month ago

Hmm. I think there was a caching problem here. I'll investigate.