phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

% submerged in the boat screen should to display the value of the boat, not the block. #130

Closed DianaTavares closed 1 month ago

DianaTavares commented 1 month ago

112 indicates that for the applications screen (boat),

Observe that the name in the panel said "% Boat submerged" because in this case, we want to know the percentage of the boat and not the block.

image

but in the actual version, we have the block: image

Also, reviewing the issue #112 there is conversation about making this panel (and density)

I'm also wondering if we should have the accordion boxes float up when closed

That action will make the simulation more clean!

zepumph commented 1 month ago

Let me know if I can help at all.

AgustinVallejo commented 1 month ago

This is done. However, as it was mentioned in the design meeting, because of the way the submerged % is calculated, the boat shows by default a 100% immersion even when floating, because the buoyant force is naturally bigger than its weight (that's how it floats).

Tracking in https://github.com/phetsims/buoyancy/issues/134 how to handle that and closing this one.

zepumph commented 1 month ago

Looks like it still says "Block". Likely it is best to let DL give a spot check on this kind of stuff, just to be sure.

image

DianaTavares commented 1 month ago

Yes, this need to said "Boat"

AgustinVallejo commented 1 month ago

Done!