search

phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Rename LiquidDensityControlNode to FluidDensityControlNode #137

Closed samreid closed 1 month ago

samreid commented 1 month ago

The UI is labeled "Fluid Density":

image

So it would be nice to rename the LiquidDensityControlNode to make it more aligned with the UI. @AgustinVallejo or @zepumph I am happy to do this if it sounds good to you.

zepumph commented 1 month ago

Yes please, let's do it.

samreid commented 1 month ago

I renamed the file and a few parameters. Want to rename these as well?

  public readonly liquidMaterialProperty: Property<Material>;
  public readonly liquidDensityProperty: TReadOnlyProperty<number>;
  public readonly liquidViscosityProperty: TReadOnlyProperty<number>;
zepumph commented 1 month ago

I think those should say because they are PhET-iO instrumented and Density is published. Were there any other API changes in density from your changes? Feel free to close.

samreid commented 1 month ago

No API changes in the commits above. Sounds good to keep those variables to match with Density. Closing.