Planet X gravity value should be hidden

phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

2 stars 2 forks source link

Planet X gravity value should be hidden #181

Open arouinfar opened 6 days ago

arouinfar commented 6 days ago

During today's design meeting, we discovered a bug. When 'Planet X' is selected, the value is displayed. In this case, the numberDisplay.visibleProperty of the Gravity control should be false.

This feature only appears in Buoyancy, so I believe this is the correct repo.

Assigning to the dev team.

AgustinVallejo commented 5 days ago

This was related to changes in https://github.com/phetsims/density-buoyancy-common/issues/239

Pushed a fix but I'm wondering something: Should the number display in mystery fluids and gravities NEVER show up? Because currently, it hides when you select planet X or density A/B, but via PhET-iO you can toggle it back on. I figured it could be used by an instructional designer to first raise the question for the gravity or density, and when students are done, display the number. But tossing back to @arouinfar for her feedback on this.

arouinfar commented 1 day ago

Back to @AgustinVallejo to use a gated visibleProperty so that the NumberDisplay can be permanently hidden with numberDispalyVisibleProperty.

AgustinVallejo commented 1 day ago

I think it was done right this time, back to Amy