phetsims / buoyancy

"Buoyancy" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 2 forks source link

Group blocks together in the tree and use more general names #62

Closed arouinfar closed 6 months ago

arouinfar commented 2 years ago

For #51

The block tandem names should be more general. Currently there are names like sameMassWood and sameDensitySmall but we can create more context by nesting things in the tree.

jonathanolson commented 2 years ago

Tandem structure should match this... however should the shapes screen have an "objects" tandem group? Also, the Shapes screen uses capsules now.

arouinfar commented 2 years ago

Thanks @jonathanolson. The checked items all look good to me.

however should the shapes screen have an "objects" tandem group? Also, the Shapes screen uses capsules now.

The capsule naming looks fine, but let's add a parent "objects" container, mirroring the structure of exploreScreen.model.blocks.

samreid commented 6 months ago

I added object levels for Shapes and also for the Applications screen:

image

This was straightforward and it seems all requests were addressed. A lot of unrelated changes appeared in the new API file. I guess I should check with @zepumph that those were intentional?? Feel free to close the isssue.

zepumph commented 6 months ago

buoyancy isn't stable, so it isn't currently getting updated very often. I have started reupdating density, buoyancy, and buoyancy:basics whenever I change the PhET-iO API of any of them. But this is just within that last 2 days. Can we all start doing that? My bound command is: grunt generate-phet-io-api --sims=buoyancy,density,buoyancy-basics