search

phetsims / calculus-grapher

"Calculus Grapher" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Ancillary tool dashed line visible in predict mode #244

Closed veillette closed 1 year ago

veillette commented 1 year ago

There has been a bit of churn with the predict mode and I think this is a bug that result from it. This was noticed on https://phet-dev.colorado.edu/html/calculus-grapher/1.0.0-dev.17/phet/calculus-grapher_en_phet.html

To reproduce, on the integral screen

All the tools associated with the area under the curve disappear except the dashed vertical line. You can do something similar with the derivative screen.

image

Assigning to @pixelzoom, since he can isolate/locate the problem more easily than me.

pixelzoom commented 1 year ago

There has been a bit of churn with the predict mode

That's an understatement :)

Remaining work in https://github.com/phetsims/calculus-grapher/issues/207 is to totally rewrite the scrubbers, which will involved reworking the entire "tool" implementation. So I'm going to wait to look at this, because I suspect the buggy code won't even exist when I get done there.

pixelzoom commented 1 year ago

Fixed in the above commit. I decided to fix this in the current implementation, so that it doesn't get report multiple times between now and when I refactor the scrubber code.