Widening of shape for PEDESTAL and HILL modes

[KatieWoe]

Test device Samsung Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/921 If you click on a line multiple times, the bump created gets wider each time. Steps to reproduce

1. On the first screen, choose either the bump or square bump option
2. Click above the line to create a bump
3. Click in the same spot again, several times

Visuals

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Calculus Grapher‬ URL: https://phet-dev.colorado.edu/html/calculus-grapher/1.0.0-dev.25/phet/calculus-grapher_all_phet.html Version: 1.0.0-dev.25 2023-03-20 03:37:03 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36 Language: en-US Window: 1536x714 Pixel Ratio: 1.25/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 4096 Texture: size: 8192 imageUnits: 32 (vertex: 32, combined: 64) Max viewport: 8192x8192 OES_texture_float: true Dependencies JSON: {}

[pixelzoom]

@veillette I think we need to communicate the names of the curve manipulation modes to QA. Maybe via a labeled screenshot? I think I know what "bump" and "square bump" mean, but it would be preferrable if we all used the same terminology.

[pixelzoom]

As for this report... I'm not sure whether this behavior is correct or not. So I'll defer to @veillette, and possibly @amanda-phet.

[veillette]

I added some terminology in https://github.com/phetsims/qa/issues/921#issuecomment-1476955029

[KatieWoe]

Hill and Pedestal is what I meant. Sorry.

[veillette]

I discussed it with @Katie, The PEDESTAL and HILL modes blend in the new function with the previous one, so the action is not unexpected per say. I'd be interested to know what @amanda-phet says.

[veillette]

This is a side effect of putting the listener on the chart rather than the curve. See for instance the old behavior version 8 versus the new one version 9 where we can widen the shape.

I think we are all in about putting the listener on the chart rectangle. but I think what I am hearing is that we would still like to have some of the previous functionalities.

[veillette]

I stand corrected, this behavior was always present, but beforehand you had to select the curve and release it multiple times, whereas now you can merely click on a point on the chart multiple times, which is much easier to do.

[amanda-phet]

Discussed with @pixelzoom and @veillette and while this is a little odd, I didn't see anyone interact with the curve this way in the 5 interviews we did. It's not exactly buggy, it just kind of makes me go "huh?" and then move on. The effect also maxes out at a certain point, so if I click a bunch in one place at a certain point I'm not seeing anything happen.

Decision: don't fix.