phetsims / calculus-grapher

"Calculus Grapher" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Revisit the display for "shift" mode #319

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

When you select the "shift" mode, the control panel looks like this:

screenshot_2474

The amount of empty space here has always bothered me a bit. An easy change would be:

screenshot_2473

But maybe there's a pedagogical reason for why the icon is the way that it currently is. @amanda-phet @veillette your opinion?

pixelzoom commented 1 year ago

If we do want to change this, here's the change for CurveManipulationDisplayNode.ts:

        else if ( mode === CurveManipulationMode.SHIFT ) {
-         curve.shift( xMax, yMax );
+         curve.shift( xMax, yMin );
        }
veillette commented 1 year ago

I think it was an oversight. Given that the slider disappears in SHIFT mode, it looks better at the yMin position.

amanda-phet commented 1 year ago

this looks better to me, to make this change.

veillette commented 1 year ago

Done in the commit above. Here is the new look! (Ignore the red outline, I was using the ?dev queryParameter)

image

Assigning to @pixelzoom to review. Feel free to close.