phetsims / calculus-grapher

"Calculus Grapher" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Screen Screenshots #335

Closed veillette closed 1 year ago

veillette commented 1 year ago

In https://github.com/phetsims/calculus-grapher/issues/1

There is an item for

We already have the main and alternate screenshots in #321, but we need screen screenshots.

We'll need screenshots before we can publish 1.0.0. The screen screenshots will need to be committed to master, then cherry-picked to calculus-grapher 1.0 branch.

According to https://github.com/phetsims/website/issues/1322

I think that screenshots should go in the assets folder in github (like https://github.com/phetsims/friction/tree/master/assets), and name them {{sim-name}}-screenshot-screen{{screen index number}}.png. It would be preferable not to save them in google drive first, but to go ahead and save them in github directly.

For example Acid Base Solutions, where the screens are "Introduction" and "My Solution", should have the following files:

assets/acid-base-solutions-screenshot-screen1.png (Introduction) assets/acid-base-solutions-screenshot-screen2.png (My Solution)

veillette commented 1 year ago

Number-play is in the same boat and after consultation with @arouinfar, it turns out not to be blocking for publication. However, the screen screenshots should still be committed to master.

amanda-phet commented 1 year ago

This is done. @veillette do you need this open? Please feel free to close.

veillette commented 1 year ago

Thanks @amanda-phet ! yes leave the issue opened as we need to cherry pick the screen screenshots for the 1.0 branch,

veillette commented 1 year ago

The files have been cherry picked in 1.0 branch.

veillette commented 1 year ago

The screen screenshots have been added to the master and 1.0 branch. Closing