Closed KatieWoe closed 11 months ago
This appears to be happening on every CT cycle, and I doubt that it's sim specific. Let's ask @zepumph.
Interesting! I have a lot of thoughts, but none of them seem to be making sense while I investigate. I originally thought that the "cause" of this may be from a bug fix I made yesterday in https://github.com/phetsims/aqua/issues/197. This would have exposed errors that were being hidden during page load for CT puppeteer testing. That doesn't seem related so far.
I cannot reproduce the issue testing with puppeteer locally.
I also wondered if I missed CG during the MR to make sure the old sim is set up to send standard wrappers for migration. That doesn't seem like a problem either.
Maybe https://github.com/phetsims/calculus-grapher/issues/338 is related, but I feel like that would show up louder than this.
Generally, I don't think this is a timeout problem, since I would expect that to be intermittent as puppeteer and sparky loads change throughout the day. This is consistent, so I believe that the timeout is downstream of the problem.
I added some logging and I will check back in on CT later.
Maybe I was just overthinking this, and CG was having trouble loading in 60 seconds normally. I boosted the timeout to 2 minutes and it seems to have fixed it. Likely the bug fix over in https://github.com/phetsims/aqua/issues/197 was the cause of seeing the trouble more often, if you go back in CT before I committed https://github.com/phetsims/aqua/commit/f32879edf7a34931f25816f6e141a90a76843df2, most of that row is empty, as if it didn't test, but I think it was buggy, and wasn't reporting the failure. I'll remove the logging and confirm fixed in a couple of rows.
Looks clear. Closing