phetsims / calculus-grapher

"Calculus Grapher" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Create unit tests for PhET-iO-only features. #339

Open zepumph opened 10 months ago

zepumph commented 10 months ago

From https://github.com/phetsims/phet-io-wrappers/issues/632, we discussed how there are Properties not used by the sim, but only created for PhET-iO viewing:

https://github.com/phetsims/calculus-grapher/blob/a6bdf8946008292b1cc10427e2be0ea4cf374210/js/common/model/AncillaryTool.ts#L105-L125

It would be nice to create a basic unit test or two to make sure that these are behaving how they should in perpetuity. We also discussed how this is most likely not worth the effort for some cases, so I defer to @pixelzoom if he would like to write any sort of code looking at this for CT.

Please feel free to just close this issue and do nothing, I mostly wanted a paper trail to note the conversation and decision about "already-developed" phet-io-only features. Thanks!

pixelzoom commented 10 months ago

Creating unit tests for PhET-iO-only Properties would be the tip of the iceberg. Calculus Grapher has many PhET-iO-only features, described in examples.md. Creating meaningful unit tests would be a large project.

I'm going to rename this issue, unassign myself, and label it as deferred for some other time.