phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Current state of PhET-iO in this simulation #241

Closed zepumph closed 6 years ago

zepumph commented 6 years ago

@Denz1994 there have been a few phet-io bugs that I've noticed while work has continued for this repo. This is totally reasonable, as there probably hasn't been an expectation for you to be working on the phet-io as you go. I'm wondering if we are keeping up on PhET-iO for this repo, or if we will catch up with it later. If it is the latter, then we may want to remove this sim from phet-io testing/building.

@ariel-phet can you specify the priority of PhET-iO in this repo. IMO it may not be too much work to maintain runnability of this sim in phet-io mode, I would rather have the upfront cost done, than to have to go back and fix potentially menial issues. I would say it is a bit of a challenge in terms of priority, because @samreid and @zepumph have limited time to support these efforts, but spending time supporting @Denz1994 now would be overall the most efficient way to go about maintaining phet-io for this sim.

Here are a few examples that I have seen recently:

Tagging @samreid in case he has opinions. @ariel-phet please comment on the best way to proceed.

Denz1994 commented 6 years ago

I just updated tandem names in the second bullet point above. It would be worth following up on the other two bullet points with @zepumph or @samreid when continuing this work.

ariel-phet commented 6 years ago

@Denz1994 @zepumph I think it would be good to keep this sim playing nicely with iO. We will plan to truly republish this sim, so since it will be on chipper 2.0, it will also be nice to have it be up to snuff on the iO side of things.

ariel-phet commented 6 years ago

As a note, @Denz1994 has a few things on his plate (this is a bit of a back burner project), so no major deadline, but as he works through the changes it will be great for him to address the iO issues as well, since he will likely be doing some instrumentation in the future.

samreid commented 6 years ago

Everything mentioned above sounds great!

zepumph commented 6 years ago

I agree with @samreid.

@Denz1994 please use the following links (but for your local server) to tests changes for phet-io:

and if there are any issues that come up that you want to discuss, please make an issue and potentially we can meet up about them.

Thanks!

@Denz1994 please close if all sounds good here.

Denz1994 commented 6 years ago

Thanks for the clarification. Closing this issue.

samreid commented 6 years ago

@KatieWoe pointed out that Bayes CT is still failing. I addressed one issue today, but there are downstream issues.

samreid commented 6 years ago

Some CT issues have been addressed, another issue noted in https://github.com/phetsims/scenery/issues/858, we can reopen this issue or another issue if there are still problems after https://github.com/phetsims/scenery/issues/858 has been addressed.