phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Inconsistent Screen Icons #246

Closed arouinfar closed 5 years ago

arouinfar commented 6 years ago

The screen icons now have different background colors. image image

I think the issue is that one screen icon is code-generated (Light Bulb) and one is an image (Capacitance), which seems odd as they are similarly simple setups. Would it be possible to convert Capacitance into a code-generated icon @Denz1994? The default configuration of the capacitor would work nicely.

If that's not feasible, here are updated assets: capacitance_screen_icon.png capacitance_screen_icon.ai

Denz1994 commented 6 years ago

The screen icons have been updated. Please review in master @arouinfar.

arouinfar commented 6 years ago

Looks great! Thanks @Denz1994

KatieWoe commented 5 years ago

Looks good on all Win 10 platforms. I'll continue to keep an eye out, but I think this can be considered done. Dev.7

Denz1994 commented 5 years ago

Good to know. Closing this one.