review use of Animation

phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 4 forks source link

review use of Animation #252

Closed pixelzoom closed 5 years ago

pixelzoom commented 5 years ago

In https://github.com/phetsims/twixt/issues/18, twixt MoveTo and OpacityTo were replaced by Animation.

Moving this last bit of work here so that the twixt issue can be closed.

8/28/18 https://github.com/phetsims/twixt/issues/18#issuecomment-415904940:

Assigning to @jonathanolson to review the replacement in capacitor-lab-basics, to decide whether he'd like to use a different variation of the Animation options, and whether to use stepper: 'timer'. Feel free to close after that review.

ariel-phet commented 5 years ago

Changing assignment to @Denz1994

Denz1994 commented 5 years ago

The refactors made in commit 3cd145acf943a4df059d288625bb6a862bc197ee where the latest relevant changes to the animation code. Since then, the refactored animation behavior has been tested in dev test cycle and has worked as intended. Closing this issue.