search

phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Timer can be lost #261

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Found on Win 10 firefox and edge so far. Does not seem to happen chrome, likely due to how chrome handles iframes. It can also happen in the normal sim by dragging to the bottom. When dragging the timer outside the bounds of the sim, it can be lost with no way to get it back without resetting the sim. losttimer For https://github.com/phetsims/QA/issues/315

ghost commented 5 years ago

The timer can also be lost in the vanilla simulation on macOS + FF via dragging it down toward the PhET menu.

issue

ghost commented 5 years ago

Timer can also be lost on iOS 9.3.5 + Safari by moving it to the right by the checkboxes.

EDIT 1: Same thing on iOS 10.3.3 + Safari.

EDIT 2: Can be lost on iOS 11.4.1 by dragging it into the lower right corner.

ghost commented 5 years ago

Timer can be lost in the same way as https://github.com/phetsims/capacitor-lab-basics/issues/261#issuecomment-490569298 on Chrome OS.

Denz1994 commented 5 years ago

DraggableTimerNode.dragbounds needed to be updated to respect the changing sim bounds. They update in correspondence with the layout bounds which keep the timer in the play area.

KatieWoe commented 5 years ago

This is looking good in 1.7.9-rc.2