phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Short strings are centered #266

Closed KatieWoe closed 3 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/321 Found on Win 10 Firefox. On the lighbulb screen, the checkboxes in the box above the voltmeter and timer are centered with short strings (stringTest=X). The first screen behaves correctly, and the checkboxes do not move. centers

KatieWoe commented 5 years ago

Edit: Wrong screenshot

arouinfar commented 5 years ago

This issue is reminiscent of https://github.com/phetsims/masses-and-springs-basics/issues/59.

@Denz1994, I would prefer that the checkboxes/radio buttons remain anchored on the left side of the panel, rather than shifting with varying string length.

KatieWoe commented 5 years ago

This is what it looks like in published: pub

ghost commented 5 years ago

I think the huge gap next to the capacitance bar is due to the centering, so we should check that this gets fixed as well.

arouinfar commented 5 years ago

Good observations @KatieWoe @lmulhall-phet. In general, the panel shouldn't ever shrink so the behavior in the published version does indeed seem strange.

I think the huge gap next to the capacitance bar is due to the centering, so we should check that this gets fixed as well.

It would be good to confirm that the bar graph is indeed shifting -- it definitely shouldn't be. It's a bit hard for me to tell (without overlapping screenshots) because the graph label alignment could be off too.

Denz1994 commented 5 years ago

The panel contents with checkboxes have been left aligned. Originally, it was centered, causing the alignment issue above. I'll verify in next RC.

phet-steele commented 3 years ago

The panel checkboxes are aligned properly in 1.7.0-rc.5, but @arouinfar do we want these to be aligned any differently?

image

If not, you can close this.

arouinfar commented 3 years ago

@phet-steele that panel looks good to me, closing.

KatieWoe commented 3 years ago

This is back in https://github.com/phetsims/QA/issues/616

jonathanolson commented 3 years ago

Should be fied in master, @KatieWoe can you verify?

KatieWoe commented 3 years ago

Putting this in issues to verify on QA board

KatieWoe commented 3 years ago

Looks fixed on master