Longer strings near capacitance, plate charge, and energy bars need more space

phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 4 forks source link

Longer strings near capacitance, plate charge, and energy bars need more space #268

Closed ghost closed 5 years ago

ghost commented 5 years ago

For https://github.com/phetsims/QA/issues/321. If you have strings that are just one character longer than the English strings next to the capacitance, top plate charge, and energy bars (not sure what else to call them?) there's no space.

Examples found by @arouinfar:

locale = uk (Ukranian)

locale = th (Thai) image (1)

arouinfar commented 5 years ago

Thanks @lmulhall-phet.

@Denz1994 a few suggestions

[ ] Move value strings 5 px to the left (pink line in screenshot below), but leave maxWidth the same. This will ensure there is some padding between the the value string and the bar graph.
[ ] Increase maxWidth of checkbox labels by 15 px (green line in screenshot below). This will still leave a reasonable amount of padding between the checkbox label and the value string (~20 px), but provide a bit more room for i18n.

Denz1994 commented 5 years ago

Alignments and maxWidth have both been adjusted. Will release a new RC for review.

KatieWoe commented 5 years ago

Looks good 1.7.0-rc.3