search

phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Inconsistent tool box size when strings are long #269

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Device Chadwick OS ChromeOS Browser Chrome Problem Description For https://github.com/phetsims/QA/issues/321. Quite minor On the first screen, the tool box with the voltmeter has the same width no matter how much the box above it grows. The corresponding toolbox on the second screen grows in width to match the box above it (the images inside do not change). In the published version both toolboxes started smaller than the box above and did not grow. It seems behavior would ideally be consistent between screens. Steps to Reproduce

  1. Open a sim with no string tests
  2. Open another sim with stringTest=long
  3. Compare tool box sizes on both screens on both sims

Screenshots: First Screen: longcap regcap Second Screen: longlight reglight Published: pub

arouinfar commented 5 years ago

Since the toolbox width now matches the panel above it, it seems a bit inconsistent that it only expands on Light Bulb to maintain equal widths. @Denz1994 seems like it should also expand on Capacitance.

While this is a minor issue, I think it would be nice to address since this sim will need to go through another RC cycle, regardless.

Denz1994 commented 5 years ago

I added an alignGroup for the checkbox panel and the toolbox panel. Both should maintain the same width when adjusted by the string size.

KatieWoe commented 5 years ago

Looks good. 1.7.0-rc.3