search

phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Use Stopwatch and StopwatchNode #272

Closed samreid closed 4 years ago

samreid commented 4 years ago

From https://github.com/phetsims/gas-properties/issues/170, DraggableTimerNode and several model properties can be replaced by StopwatchNode and Stopwatch. I've made these changes in my working copy, this issue is to facilitate review. After I commit, I'll reassign to the responsible dev for review.

samreid commented 4 years ago

@Denz1994 can you please review at your convenience?

Denz1994 commented 4 years ago

It looks like using model.Stopwatch centralized a lot of the model components previously used by draggableTimerNode (now StopwatchNode). This looks a lot cleaner. Thanks for the change @samreid. Closing this one.