Should arrows change if the type is changed while another is present

phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 4 forks source link

Should arrows change if the type is changed while another is present #281

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

For https://github.com/phetsims/QA/issues/588. This is a suggestion and not much of an issue, so feel free to close if this isn't needed. When charges move and current direction arrows are on, the blue or red arrow will appear for a time and then disappear. If you switch options (from electrons to conventional or vice versa) while that arrow is visible, nothing changes. Should the arrow change in this case? Seen more easily if speed is set to slow or paused. shouldarrowchange

arouinfar commented 3 years ago

Good find, @KatieWoe. This actually looks like a bug to me because the current arrow becomes out of sync with the selected radio button. @Denz1994 is it possible to switch arrow type midway? If not, we could immediately hide the current arrow rather than continuing to display the wrong arrow type until it fades away.

jonathanolson commented 3 years ago

There was a LOT of weird handling here... I changed a lot of this code, and I believe this should now work nicely in master. @KatieWoe can you verify?

KatieWoe commented 3 years ago

This part looks ok on master.

KatieWoe commented 3 years ago

Looks ok in dev.5. Closing