Current Direction buttons still activated when Current Direction is off

phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 4 forks source link

Current Direction buttons still activated when Current Direction is off #283

Closed brooklynlash closed 3 years ago

brooklynlash commented 3 years ago

This is for https://github.com/phetsims/QA/issues/616, seen on Win10. caplabbasics When the "Current Direction" is deselected, you can still click the conventional and electrons current buttons. Should those also be disabled?

arouinfar commented 3 years ago

Nice find @brooklynlash!

@jonathanolson this looks like a regression, see https://github.com/phetsims/capacitor-lab-basics/issues/278.

jonathanolson commented 3 years ago

Cherry-picked into master, @brooklynlash can you verify this is fixed?

brooklynlash commented 3 years ago

Fixed in master! Closing