search

phetsims / capacitor-lab-basics

"Capacitor Lab: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Phet-io mirror wrapper doesn't work and studio doesn't launch #291

Open KatieWoe opened 3 years ago

KatieWoe commented 3 years ago

For https://github.com/phetsims/QA/issues/642. Seen on Win 10 Chrome. Found in https://phet-dev.colorado.edu/html/capacitor-lab-basics/1.6.20-rc.1/phet-io/wrappers/mirror-inputs/mirror-inputs.html and https://phet-dev.colorado.edu/html/capacitor-lab-basics/1.6.20-rc.1/phet-io/wrappers/instance-proxies/instance-proxies.html?sim=capacitor-lab-basics&relativeSimPath. The mirror image wrapper does not show a sim either upstream or downstream. In the studio (instance proxies) changes can be made, but pressing launch leads to a blank screen.

launchblank

nomirror
KatieWoe commented 3 years ago

@jonathanolson have you ever run into this trouble before while MRing this version?

KatieWoe commented 3 years ago

This is happening with resistance in a wire as well. https://phet-dev.colorado.edu/html/resistance-in-a-wire/1.3.13-phetiorc.1/resistance-in-a-wire_en-phetio.html?phetioStandalone

zepumph commented 3 years ago

This issue seems to be because older phet-io releases make assumptions that it is deployed into the version directory, and not nested in the phet-io/ directory. I can't be sure though.

jonathanolson commented 3 years ago

Got this fixed up above, links should be working for next RC testing (don't recommend testing yet): https://phet-dev.colorado.edu/html/capacitor-lab-basics/1.6.20-rc.2/phet-io/wrappers/mirror-inputs/mirror-inputs.html and https://phet-dev.colorado.edu/html/resistance-in-a-wire/1.3.13-phetiorc.2/wrappers/mirror-inputs/mirror-inputs.html

jonathanolson commented 3 years ago

Reopening for tracking.

phet-steele commented 3 years ago

@jonathanolson every single instance-proxies wrapper we are asked to test in phetsims/QA/issues/649 fails to "Launch" on my Win 10 Chrome. They each fail with one of two errors.

The following sims fail with this error: Uncaught ReferenceError: QueryStringMachine is not defined

Then these sims fail with this error: ReferenceError: SimIFrameClient is not defined

KatieWoe commented 3 years ago

It looks like some mirror inputs may fail as well. This is faradays law.

mirrorfaraday
KatieWoe commented 3 years ago

Other sims like balloons and static electricity have the mirror wrapper issue still too.

mirrorballoon
jonathanolson commented 3 years ago

@kathy-phet, it seems like a lot of these have been broken for a while, and aren't broken by this maintenance release. Should this be looked into separately, or should I be fixing it as part of this release?

kathy-phet commented 3 years ago

@KatieWoe - Are all these failures exhibited on the current published version too? See this list: https://docs.google.com/spreadsheets/d/e/2PACX-1vReSXUUxC63CQCKHIoO6qY4ycWrqgw8eaX25io3_r2hRmO3RbXuyNRRMz5J2C1c5mCN9nxumvrv6snj/pubhtml?gid=2141068918&single=true

I tried Balloons and Static Electricity Link, and it seemed to work.

@samreid - Can you chime in here about why instance proxies is failing to Launch with this maintenance release pick? @jonathanolson - I would say that maintenance releasing to these PhET-iO sims isn't a priority, but we cannot release something that doesn't work because instance proxies works on the published versions. And yes, clients are still using these versions. Previously you said we cannot skip the PhET-iO release and get the PhET brand release. Has that changed, or is that still correct?

kathy-phet commented 3 years ago

Another option would be to deploy these but then manually delete the phet-io versions from the production servers. That way the clients would be server the existing working phet-io versions, and we can still use the automated deploy tools for phet maintenance? I think.

KatieWoe commented 3 years ago

Beers Law Lab had this issue when trying to launch from studio:

beerslawstudio

Otherwise, studio and mirror wrapper seem to load properly in the sims linked in https://github.com/phetsims/capacitor-lab-basics/issues/291#issuecomment-849205773

samreid commented 3 years ago

If I recall correctly, we discussed this further on Thursday. @jonathanolson do you recall that discussion and can you summarize?

kathy-phet commented 3 years ago

@samreid - I believe we found that these work when published, but do not work as dev or rc versions. So we decided to proceed with the maintenance release and then check that they are indeed working on the published website.

liammulh commented 3 years ago

Studio still isn't launching in https://phet-dev.colorado.edu/html/resistance-in-a-wire/1.3.13-phetiorc.4/wrappers/instance-proxies/instance-proxies.html?sim=resistance-in-a-wire&relativeSimPath for https://github.com/phetsims/QA/issues/653.

jonathanolson commented 3 years ago

Can we check these on the production site now @KatieWoe?

KatieWoe commented 1 year ago

I must have missed this when it was first assigned to me. I apologize. According to @kathy-phet it looks like launching is still broken in published. Discussion also seen in https://github.com/phetsims/qa/issues/859. What can I do to help?

KatieWoe commented 1 year ago

I'm also unsure where to find a list of the published Instance Proxies for future testing/work. Can someone provide this?

arouinfar commented 1 year ago

Capacitor Lab: Basics has only partial PhET-iO. It was never designed or released publicly. Anything that would have been shared would have been with a research partner with the understanding it was a one-off with no real support.