Closed catherinecarter closed 1 year ago
Do you mind mocking up how this would look for the IQR? Right now the brackets at the top are positioned so that they don't overlap with the title of the accordion box or other elements in the info box, so moving the box and whisker plot up would create issues with this.
Looking through the code it seems like this would be fairly straightforward for the main accordion box displays, but non-trivial for the info boxes since the height of the rectangle is dynamic and has different logic for the three measures. The MAD node can get particularly tall, so we'd need more specifics on how this should look for cases with tall stacks of data if we were to implement it in the info displays.
That's a good point about the median arrow getting in the way of the rectangle height. What do you think of this?
In terms of the info box, I think the rectangles there being different sizes are ok. In the accordion box, though, since a user can toggle between all of them quickly, the disparity in height is much more jarring.
Looking really nice! Ready for your review @catherinecarter :)
Looks really good! I am keeping this issue open because when the accordion box is extended in height, we may have to revisit this issue again to see how tall we want the rectangles while staying under the title.
This has been fixed as part of 1473f9c and design review complete by @catherinecarter. Closing.
Reopening to address remaining TODO
All TODOs have been addressed and the variability rectangles are sizing correctly. Closing.
I noticed the rectangles in the accordion box are different heights for the different measures. Let's make them all match, especially after issue #279 is complete, we may want to revisit the heights of these rectangles as the size of the accordion box will be increasing.