Closed catherinecarter closed 1 year ago
Ready for design review @catherinecarter!
It looks really good when the data points are very spread out, as in the case of a maximum height of 1 ball, like this:
When there are two or more balls in a stack, though, the same feeling of disproportionate exists since the rectangle becomes closer to the top of the stack, making the rectangle actually feel smaller, like this:
Or this:
Can we add a consistent padding above the top marker so the height of the rectangle feels less crowded (maybe 2 ball markers)? Looking at the above pics and the ones below, the spacing between the top of the plot marker (x or dot) and the top of the rectangle seems inconsistent:
Sounds good @catherinecarter - I set the top padding of the rectangle to be the height of 1.5 data points. Let me know if you like it as is or if it should also have a mimimum height for shorter data sets.
Reviewed with @catherinecarter and noted two things:
We plan to revisit this issue after resolving the discussion about the size of the data points. Will mark as 'on hold' for now.
The rectangle padding needs to take into account DATA_POINT_SCALE_PROPERTY
. Will pair with @matthew-blackman on this.
The range rectangle padding was updated. @catherinecarter can you review?
I also tried increasing the scaling of the points, but since we want them to cut off at the halfway point I was a bit limited. If we do want to increase the scale, probably best to do that synchronously. Otherwise if all looks good feel free to close!
I think it looks great. The margin is a little bigger for 30, but not to the point where it needs more tweaking. Ready to close. Thanks, @marlitas!
The height of the rectangle in the info box (for Range) is disproportionately small compared to the height of the rectangle in the accordion box, and the space between the Range value on the left and the range value above the rectangle is very large. Let's put a minimum height on that rectangle so it looks more proportional. Not sure how big to make it, maybe 2.5 times higher?