search

phetsims / center-and-variability

"Center and Variability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

Extra focus highlight in median info dialog #584

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 14.0

Browser Chrome

Problem description For https://github.com/phetsims/qa/issues/993, I am able to tab to the cards in the median info dialog.

Steps to reproduce

  1. On the Median Screen, tab to and open the info dialog
  2. Press tab

Visuals

Screenshot 2023-10-16 at 8 15 10 AM
marlitas commented 1 year ago

Fixed above. Over to @samreid or @matthew-blackman for review.

samreid commented 1 year ago

I'll review this

samreid commented 1 year ago

Code change and runtime behavior look great. I'll label as ready for cherry-pick.

Nancy-Salpepi commented 1 year ago

looks good in rc.3