search

phetsims / center-and-variability

"Center and Variability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

Able to set ball position at values greater than 15 #595

Closed Nancy-Salpepi closed 11 months ago

Nancy-Salpepi commented 11 months ago

Test device MacBook Air M1 chip

Operating System 14.0

Browser Chrome

Problem description For https://github.com/phetsims/qa/issues/999, when customizing the kickDistributionStrategy I am able to set a ball's value greater than 15. Shouldn't an error pop up in studio?

Steps to reproduce

  1. In studio, on any screen, change the kickDistributionStrategy to distanceByIndex by copying and pasting the example data in the text box.
  2. Change the first value from 5 to 16 and press Set Value
  3. Press Kick 1

Visuals

Screenshot 2023-10-25 at 9 40 55 AM Screenshot 2023-10-25 at 9 41 14 AM
marlitas commented 11 months ago

I also noticed that you can set the ball position to non-integers. Kind of fun, but probably buggy:

image

marlitas commented 11 months ago

I added some checks for this that will provide an error message. Over to @samreid or @matthew-blackman for review. I especially want to confirm that the error messages are appropriate.

marlitas commented 11 months ago

This was reviewed and is now ready for cherry pick.

Nancy-Salpepi commented 11 months ago

Looks good in rc.4.