search

phetsims / center-and-variability

"Center and Variability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

String keys were renamed! Ensure we don't lose translations #601

Open zepumph opened 10 months ago

zepumph commented 10 months ago

Over in https://github.com/phetsims/soccer-common/commit/75c9aee5a2d34406928ced240512b2163683e393 we moved some translated strings over to joist. Unfortunately this occurred after CAV was published. This means that CAV is going to be getting translations for these strings for the lifetime of 1.1 (which is a PhET-iO hydrogen sim, so likely many years). This issue so that when next we publish 1.2, to double check the soccerCommon strings and make sure that there are no translations there that aren't also in the joist versions. This is needed for the following strings:

soccerCommon.characterSet.africaModestStringProperty
soccerCommon.characterSet.africaStringProperty
soccerCommon.characterSet.unitedStatesOfAmericaStringProperty

Moved to:

joist.preferences.tabs.localization.regionAndCulture.portrayalSets.africaModestStringProperty
joist.preferences.tabs.localization.regionAndCulture.portrayalSets.africaStringProperty
joist.preferences.tabs.localization.regionAndCulture.portrayalSets.unitedStatesOfAmericaStringPropert