search

phetsims / center-and-variability

"Center and Variability" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

CardNode cursor should be on the whole draggable area #609

Closed zepumph closed 9 months ago

zepumph commented 9 months ago

Discussed briefly with @marlitas and @jbphet while working on https://github.com/phetsims/scenery-phet/issues/815 and https://github.com/phetsims/center-and-variability/issues/605, and then with @jonathanolson. @jonathanolson and I highly recommend having the cursor set on the Node that gets the input listener. This way we would have the cursor on the whole mouse area specified by CardNode.

zepumph commented 9 months ago

After the above commit, we now have a cursor on the whole touch area (including on the drag cue hand/arrow). This is much nicer given the code we have to expand mouse areas:

image

@marlitas can you please review and let me know if there are any problems. I didn't see any other usages of CardNode to worry about.

marlitas commented 9 months ago

This change looks great, and definitely seems like an improvement. Thanks!